shalinshah1993 / SBSCL

The Systems Biology Simulation Core Library (SBSCL) provides an efficient and exhaustive Java implementation of methods to interpret the content of models encoded in the Systems Biology Markup Language (SBML) and its numerical solution.
https://draeger-lab.github.io/SBSCL/
GNU Lesser General Public License v3.0
0 stars 2 forks source link

Solver libraries should be separate artefacts #19

Closed matthiaskoenig closed 6 years ago

matthiaskoenig commented 6 years ago

The jar files for the solvers are not artefacts. This will generate issues for people including this repository. See

https://stackoverflow.com/questions/32384798/dependencies-should-not-point-at-files-within-the-project-directory#32384847 https://stackoverflow.com/questions/4955635/how-to-add-local-jar-files-to-a-maven-project

mkoenig@prime1:~/git/sbscl-shalin$ mvn clean install -DskipTests
[INFO] Scanning for projects...
[WARNING] 
[WARNING] Some problems were encountered while building the effective model for org.simulator:sbscl:jar:1.5
[WARNING] 'dependencies.dependency.systemPath' for nmi:scpsolver:jar should not point at files within the project directory, ${project.basedir}/src/lib/nmi/scpsolver/1.0/SCPSolver-1.0.jar will be unresolvable by dependent projects @ line 208, column 19
[WARNING] 'dependencies.dependency.systemPath' for nmi:glpksolver:jar should not point at files within the project directory, ${project.basedir}/src/lib/nmi/scpsolver/1.0/GLPKSolverPack.jar will be unresolvable by dependent projects @ line 215, column 19
[WARNING] 'dependencies.dependency.systemPath' for nmi:lpsolver:jar should not point at files within the project directory, ${project.basedir}/src/lib/nmi/scpsolver/1.0/LPSOLVESolverPack.jar will be unresolvable by dependent projects @ line 222, column 19
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: junit:junit:jar -> version ${junit.version} vs 4.11 @ line 224, column 17
[WARNING] 
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING] 
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING] 

I will fix this with some other maven issues.