search

shalinshah1993 / SBSCL

The Systems Biology Simulation Core Library (SBSCL) provides an efficient and exhaustive Java implementation of methods to interpret the content of models encoded in the Systems Biology Markup Language (SBML) and its numerical solution.
https://draeger-lab.github.io/SBSCL/
GNU Lesser General Public License v3.0
0 stars 2 forks source link

Fix #37, L1V2 SED-ML examples added #39

Closed matthiaskoenig closed 6 years ago

matthiaskoenig commented 6 years ago

This adds L1V2 test cases in the /src/test/resources/sedml/L1V2 folder.

draeger commented 6 years ago

It worries me a bit is that we now have a lot of redundant files in this repository that may be changed, maintained, and updated elsewhere, leading to a divergence over time.

What do others think? Wouldn't it be better to include a script that obtains SED-ML files etc. from the original location? We could then make sure that developers of SBSCL keep their individual copies outside of this repo?

niko-rodrigue commented 6 years ago

For junit tests, it is better to be sure that the data will not change. We don't want to have the updates or changes or losing some file if location change. If you can target a specific version that we are sure will not change or be unavailable at some point that might be fine.

matthiaskoenig commented 6 years ago

I think in case of the SED-ML files it is okay to put them in the repository. In total all the files are only <1MB. If this is getting too big, we can first put the files in omex archives, as a second would be to load them analoque to the BiGG and sbml-test-case files. But for now, I don't think the files are a problem.