search

shallwefootball / upload-s3-action

github action for upload to S3 ☁️
https://github.com/marketplace/actions/upload-s3
166 stars 158 forks source link

[quality]: Make the `destination_dir` trailing slash optional #11

Closed kittaakos closed 4 years ago

kittaakos commented 4 years ago 
- uses: shallwefootball/s3-upload-action@master
  with:
    aws_key_id: ${{ secrets.AWS_KEY_ID }}
    aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY}}
    aws_bucket: ${{ secrets.AWS_BUCKET }}
    source_dir: path/to/source/
    destination_dir: path/to/dest

The above config generates the following upload location URL for my my_file.zip: https://***.s3.amazonaws.com/path/to/destmy_file.zip which is very wrong.

It would be great if this action could handle this gracefully, and append the trailing slash.

kittaakos commented 4 years ago

I am going to provide PR for this.

shallwefootball commented 4 years ago

try to v1.1.0