search

shallwefootball / upload-s3-action

github action for upload to S3 ☁️
https://github.com/marketplace/actions/upload-s3
163 stars 150 forks source link

feat: Configurable ACL #58

Open zachelrath opened 1 year ago

zachelrath commented 1 year ago

This PR adds the ability to configure the ACL used when uploading objects via an "acl" parameter

WoodyWoodsta commented 8 months ago

Personally, I feel as though the default should not be anything public. Some user's may not catch this. Making uploaded content publicly accessible should be opt-in.

zachelrath commented 8 months ago

@WoodyWoodsta Totally agree, but that would be a breaking change, and would need to be done in a major release. I was just preserving the previous default behavior. But I absolutely agree, this is why we need a configurable ACL for this action, defaulting content to be publicly-accessible makes this GH Action unusable for a lot of enterprise use cases, which is a shame because otherwise it is very helpful! I had to fork the repo just to configure a non-public ACL.

Doesn't seem like @shallwefootball is actively maintaining this repo either, so it may be a moot point, I submitted this PR 8 months ago.

WoodyWoodsta commented 8 months ago

I've resorted to a different action.

zachelrath commented 8 months ago

@WoodyWoodsta Make sense, which other action are you using?

WoodyWoodsta commented 8 months ago

https://github.com/marketplace/actions/simple-s3-upload

Yet to test if it's working as expected, but the code is simple.