search

shallwefootball / upload-s3-action

github action for upload to S3 ☁️
https://github.com/marketplace/actions/upload-s3
166 stars 158 forks source link

Upgrade to node20 #64

Open grzegorzkrukowski opened 10 months ago

grzegorzkrukowski commented 10 months ago

This action requires Node20 to comply to latest GitHub requirements:

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

grzegorzkrukowski commented 9 months ago

@shallwefootball is there a chance this action will be compliant with the requirements or should we fork it instead and maintain it on our fork? Thanks in advance!

grzegorzkrukowski commented 9 months ago

GitHub will enforce Node20 on May 13 - is there a chance this gets updated by that time?

lvthanh03 commented 7 months ago

+1 for upgrading to node20.

xanderhendriks commented 6 months ago

@shallwefootball I also pushed PR 67 again from my fork. I went through the same process as in my earlier PR 46 Sorry @lvthanh03 I didn't see your update before making the changes in my fork. I did notice you didn't update the dependencies. Last time that gave me warnings, so I updated them again as part of the PR. But even then I still see one warning regarding updating the aws-sdk to version 3. I would be interested to know how to do this if everyone has come across this before as the version it upgraded to is the latest on the npmjs website.

xanderhendriks commented 6 months ago

Looks like we still have some time before the current version of the action will stop working: https://github.blog/changelog/2024-05-17-updated-dates-for-actions-runner-using-node20-instead-of-node16-by-default/

grzegorzkrukowski commented 4 months ago

It's fixed now with this commit also there is a PR opened to update te dependencies.

We need a new release to close this issue as not there is no way to use a fixed version as an action :(