search

shalvah / RemindMeOfThisTweet

🤖 Twitter bot to set reminders for tweets.
https://remindmeofthis.app
GNU General Public License v3.0
414 stars 41 forks source link

Limit reminder duration #28

Closed shalvah closed 3 years ago

shalvah commented 3 years ago

People shouldn't be able to set reminders for a 100 years in the future.😕 Let's cap it at say, 30 years.

Fixing this should be pretty straightforward—add a maximum reminder time (there's already a minimumReminderTime):

https://github.com/shalvah/RemindMeOfThisTweet/blob/54391d1db98a4ca3046a09401b666e1fbd015f5d/src/factory.service.js#L28

(If you work on this, don't forget to add a test; you can follow the minimum reminder time test, or let me know if you need help.)

olucurious commented 3 years ago

Just sent a PR here https://github.com/shalvah/RemindMeOfThisTweet/pull/29 Let me know what you think

shalvah commented 3 years ago

Fixed in https://github.com/shalvah/RemindMeOfThisTweet/pull/29