shalvah / oldtweets.today

"On This Day" for Twitter #TwitterThrowback
http://oldtweets.today
113 stars 24 forks source link

Major Style Revamp #14

Closed adedayomoshood closed 5 years ago

adedayomoshood commented 5 years ago

Semantic HTML Update Viewport to avoid user zooming

default-view loading error
shalvah commented 5 years ago

I like the effort @adedayomoshood. We're going to need to discuss this change, though.

👍:

🤔 :

Also:

ooade commented 5 years ago

BTW, I'll suggest the developer thing goes to the bottom, that is, the content comes first. Except you're building only for developers

adedayomoshood commented 5 years ago
  • The background: I dislike plain white backgrounds. They hurt my eyes (and others like me)

I intend to update such that we have a dark mode, just like we have on Twitter. I love dark modes too. Since it's a Twitter Throwback, I though is should look "Twitter" as much as it can.

  • Centering the hero text vertically looks nice, but I feel this could be problematic on mobile—there wouldn't be enough space to show the results on the first viewport (This is important so users know there's content there.)

Yes, I understand that centering the hero text vertically will be an issue when the results have been displayed, especially on mobile devices. I already put that into consideration and catered for that. Once the search is successful, Some information are removed from the screen to provide additional space for the result to be displayed on the screen. With that, the users doesn't need to scroll down before they can see results.

screenshot 2019-02-18 at 10 38 23 Mobile Screen

screenshot 2019-02-18 at 10 39 13 Mobile Screen with results

  • The loading text could be bigger. As it is, I can barely see it.

That's true. I'll try put a border around just like the error messaging.

  • how about mobile screenshots?

Mobile screenshots published in #15 I'll update this with mobile.

shalvah commented 5 years ago

I intend to update such that we have a dark mode, just like we have on Twitter. I love dark modes too. Since it's a Twitter Throwback, I though is should look "Twitter" as much as it can.

I think you should hold off on this for now, until we've decided whether to go forward with this. Here are my issues:

Yes @ooade we could take the developer thing down. That should be in a separate PR, though.

BolajiAyodeji commented 5 years ago

@adedayomoshood I think you just make it a bit dark, something that works like the current UI with less contrast. You can use some dark animated SVG for the background and keep the other styles, the button and the rest still looks great. What do you think?

shalvah commented 5 years ago

Also, I'd say 'No" to a dark mode. This is a simple website, and I don't feel it's a good investment to spend time in creating an alternate pair of styles (and fitting an extra UI element to toggle "Dark Mode").

BolajiAyodeji commented 5 years ago

Also, I'd say 'No" to a dark mode. This is a simple website, and I don't feel it's a good investment to spend time in creating an alternate pair of styles (and fitting an extra UI element to toggle "Dark Mode").

I meant just dark, no alternative style or toggling here. The other styles in this context are the buttons

adedayomoshood commented 5 years ago
  • I don't think it should necessarily look like Twitter. I feel having a different look distinguishes it from an official Twitter product.

  • The blue and white feels monochrome-y and "professional". Maybe it's just me, but I feel it detracts from the fun look I prefer. It makes the page feel dull to me, while the current design feels light-hearted and playful.🤷‍♀️

  • Less contrast between the page and the Tweets. This would be even more pronounced if there's a dark mode.

Hmmmm okay, I get that. I used blue and white are the colors used in Twitter, it'll be easy for a user to know it is "twitter related". I believe if someone is able to create a non-twitter logo.

Alternatively, we can do a dark theme instead. Something like what we have below.

screenshot 2019-02-18 at 14 27 25

Yes @ooade we could take the developer thing down. That should be in a separate PR, though.

The developer thing actually disappears once there's results.

ooade commented 5 years ago

Haa! @adedayomoshood Disappear ke? It should just be at the bottom, don't let it disappear.

adedayomoshood commented 5 years ago

Haa! @adedayomoshood Disappear ke? It should just be at the bottom, don't let it disappear.

Lol! What I mean is once you see results, you may not necessarily need it any longer. Or maybe after the results list sha. 😉

shalvah commented 5 years ago

Hey @adedayomoshood I appreciate the time and effort you've put into this, but I prefer to keep the current design. Summary of my reason: the proposed design, while perfectly fine in its own right, feels too "formal", and is not in line with what I have in mind for this product. Thanks!