search

shalvah / oldtweets.today

"On This Day" for Twitter #TwitterThrowback
http://oldtweets.today
113 stars 24 forks source link

Url state #28

Closed oneEyedSunday closed 5 years ago

oneEyedSunday commented 5 years ago

Fixes 27. One caveat though, I've left the setting of window.username till when the form is submitted. i.e. a search performed.

shalvah commented 5 years ago

I've left the setting of window.username till when the form is submitted. i.e. a search performed.

Good idea. But maybe we should also leave the setting of the date to after the search. 🤔

oneEyedSunday commented 5 years ago

Thing is, without that, if i share you a link to my tweets on a day. You'd just come to the page without the day I shared you being prefilled. I feel it goes against the idempotent nature we are going for.

oneEyedSunday commented 5 years ago

@shalvah so I've fixes the issue with the globals. I think you should raise an issue about the hash and inconsistent use of ? v & for the query params. So this PR doesn't get unnecessarily bulky.

oneEyedSunday commented 5 years ago

@shalvah so I've fixed the inconsistencies with the query params which you can see clearly in this commit here

shalvah commented 5 years ago

Thanks