search

shalvah / oldtweets.today

"On This Day" for Twitter #TwitterThrowback
http://oldtweets.today
113 stars 24 forks source link

Display user's tweet in Grid #3

Closed BolajiOlajide closed 5 years ago

BolajiOlajide commented 5 years ago

Description

Same as title.

screenshot 2019-02-16 at 3 39 05 am

shalvah commented 5 years ago

Thank you. +1 for the screenshot.

The different heights of the tweets make it look a bit odd. Is there anything we can do about that? Is bottom alignment the best?

Also, how does it look on mobile?

BolajiOlajide commented 5 years ago

Yeah, should have submitted it as a draft( (or WIP). The different heights of the card make it odd but I'm thinking if one can make it into the mosaic design such that they fit into themselves. The only problem with that is that it'll affect ordering.

I'll send a screenshot of mobile but basically, it's one column on mobile that goes all the way down.

shalvah commented 5 years ago

Okay. Ordering isn't really a major factor within years. We can tolerate minor discrepancies in order.

On Sat, 16 Feb 2019, 12:38 Bolaji Olajide, notifications@github.com wrote:

Yeah, should have submitted it as a draft( (or WIP). The different heights of the card make it odd but I'm thinking if one can make it into the mosaic design such that they fit into themselves. The only problem with that is that it'll affect ordering.

I'll send a screenshot of mobile but basically, it's one column on mobile that goes all the way down.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/shalvah/oldtweets.today/pull/3#issuecomment-464339442, or mute the thread https://github.com/notifications/unsubscribe-auth/ANsh8Xz7n0G57s6XFoZoEwqyvNmzF3uNks5vN-3GgaJpZM4a-vMR .

ooade commented 5 years ago

It could be done with column-count. I did something like that here.

BolajiOlajide commented 5 years ago

@ooade I don't think column-count will do the trick here because the tweets are categorized by the year and you might have a column extremely long and others short. I'm drifting towards a grid-auto-flow: dense scenario but looking at how that will work for example with categories that have just 2 tweets.

I've been swamped with a number of things recently so you're welcome to try it out if you are chanced, if not I'll revisit this soonest and propose a solution with screenshots.

cc @shalvah

shalvah commented 5 years ago

Probably best to hold off on this for the time being.