shalvah / oldtweets.today

"On This Day" for Twitter #TwitterThrowback
http://oldtweets.today
113 stars 24 forks source link

Add Share functionality #4

Closed shalvah closed 5 years ago

shalvah commented 5 years ago

It would be nice to have a Share button on the page, allowing users to share their results (probably with the hashtag). Unfortunately, putting it below the results will likely make users miss it. Putting it above might work, but we already have two lines of information there.

shalvah commented 5 years ago

"Share to Twitter"

Contents should be something like: "Here's my #TwitterThrowback. Check yours here", then link to oldtweets.today/#their-username

On Sat, 16 Feb 2019, 12:47 Bolaji Ayodeji, notifications@github.com wrote:

What contents should the share hold? Something like: I just checked what I tweeted on this day in the past with #oldtweets.today, check your's here. . ? Preferred social media?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/shalvah/oldtweets.today/issues/4#issuecomment-464340094, or mute the thread https://github.com/notifications/unsubscribe-auth/ANsh8a8Ohix5jgFLiBdzbCoP0o7acFuIks5vN-_IgaJpZM4a-4Fi .

BolajiAyodeji commented 5 years ago

Okay! Let me work on this. #their-username here should be the sharer's username or the username checked via the app?

Lekky71 commented 5 years ago

Cool, question though, "Here's my #TwitterThrowback...", what does it return exactly? A link to the throwback tweet? If so, what about if the throwback tweets are more than one.

BolajiAyodeji commented 5 years ago

I think it should just link back to the app, there might be no need of adding the user's throwback. More like "Here's my #TwitterThrowback. Check yours here", then link to oldtweets.today What do you think?

shalvah commented 5 years ago

"Here's my Twitter throwback" implies that you're linking them to your results. So the link should be # That takes them to a page with your username filled in, so they just need to click the button. They can also replace the username with theirs and check.

On Sat, 16 Feb 2019, 14:28 Bolaji Ayodeji, notifications@github.com wrote:

I think it should just link back to the app, there might be no need of adding the user's throwback. More like "Here's my #TwitterThrowback. Check yours here", then link to oldtweets.today What do you think?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/shalvah/oldtweets.today/issues/4#issuecomment-464347130, or mute the thread https://github.com/notifications/unsubscribe-auth/ANsh8bFEi5X5f8Dc0c50zZmDOEICCy7rks5vOAd_gaJpZM4a-4Fi .

Lekky71 commented 5 years ago

Oh, cool. The search form query can be made automatically 'on page load' since the username is already filled in, so once someone that clicked on the shared link sees the throwback; they can just edit the text field with their Twitter username to see theirs.

Lekky71 commented 5 years ago

@shalvah Twitter doesn't allow hashtags in their tweet-to link, there's a query that accepts hashtags, What this means is that http://oldtweets.today/#${window.username} would not be possible. This is a blocker.

shalvah commented 5 years ago

Okay, no problem. We can do http://oldtweets.today/?username=${window.username}. The code already supports that.

shalvah commented 5 years ago

Oh, cool. The search form query can be made automatically 'on page load' since the username is already filled in, so once someone that clicked on the shared link sees the throwback; they can just edit the text field with their Twitter username to see theirs.

Yes, we could do that too. Submit the form when the page is loaded with a preset value.

Lekky71 commented 5 years ago

Cool

shalvah commented 5 years ago

Closed in #7