search

shalvah / oldtweets.today

"On This Day" for Twitter #TwitterThrowback
http://oldtweets.today
113 stars 24 forks source link

Feature: store last used username in local storage #40

Closed shalvah closed 3 years ago

shalvah commented 3 years ago

...and prefill the text box on page load.

That way, a frequent user won't have to retype their handle each time.

Note: if the page is visited with a query parameter username=<username>, that should overwrite the last used username (until the user types something else).

calebdeji commented 3 years ago

Hi Shalvah, I would like to raise a pull request for this.

shalvah commented 3 years ago

Sure, go ahead.

On Fri, Jan 1, 2021, 12:35 P. Caleb Ogunwale notifications@github.com wrote:

Hi Shalvah, I would like to raise a pull request for this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/shalvah/oldtweets.today/issues/40#issuecomment-753305670, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADNSD4NA3CDAXF7EDZCVBOLSXWXQFANCNFSM4VQGJTIA .

calebdeji commented 3 years ago

Hi Shalvah, I wanted to make a PR now but I noticed there are a lot of changes made due to formatting, I think it would be preferable to have a base formatter configuration like .prettierc.

Is it okay to still make the PR?

shalvah commented 3 years ago

Errr... I'd prefer to have it without the formatting changes. Disable Prettier or whatever you use for the project and make your changes.

calebdeji commented 3 years ago

Errr... I'd prefer to have it without the formatting changes. Disable Prettier or whatever you use for the project and make your changes.

Okay.

shalvah commented 3 years ago

Closed in #41