search

shalvah / oldtweets.today

"On This Day" for Twitter #TwitterThrowback
http://oldtweets.today
113 stars 24 forks source link

modifed project structure #5

Closed BolajiAyodeji closed 5 years ago

BolajiAyodeji commented 5 years ago

I modified the project structure

image

shalvah commented 5 years ago

Good work. I'd rather keep the styles in the page though. I believe it makes the page load faster (no extra request for stylesheet).

BolajiAyodeji commented 5 years ago

Good work. I'd rather keep the styles in the page though. I believe it makes the page load faster (no extra request for stylesheet).

Okay, would take it in. The script also? I see you made more changes also.

shalvah commented 5 years ago

I'm not sure you resolved conflicts correctly. Looks like the showError function is missing. Can you just copy and paste the JS code from master?

BolajiAyodeji commented 5 years ago

Okay, let me check!

BolajiAyodeji commented 5 years ago

@shalvah Its fixed now

BolajiAyodeji commented 5 years ago

Back to top feature; image

shalvah commented 5 years ago

Cool!

shalvah commented 5 years ago

Sweet! Nice touch with the "Back to top" button.