shalvah / oldtweets.today

"On This Day" for Twitter #TwitterThrowback
http://oldtweets.today
113 stars 24 forks source link

Improve button and input styling #6

Closed shalvah closed 5 years ago

shalvah commented 5 years ago

When the search is running, the button is disabled, but there are no styles or the ":disabled" state, so the UI doesn't reflect this.

Also, it would be ideal if the button moves below the search bar on mobile (so the input's placeholder text isn't truncated). In such a case, we'd need to round out all the borders of both input and button.

BolajiAyodeji commented 5 years ago

I thought as much. Would look into this

adedayomoshood commented 5 years ago

When the search is running, the button is disabled, but there are no styles or the ":disabled" state, so the UI doesn't reflect this.

Also, it would be ideal if the button moves below the search bar on mobile (so the input's placeholder text isn't truncated). In such a case, we'd need to round out all the borders of both input and button.

I have created a PR to fix this #14

shalvah commented 5 years ago

This issue is still open, if anyone's interested. The button doesn't change appearance when in the disabled state, and neither does its pointer.

oneEyedSunday commented 5 years ago

I created a PR for updated the button while its disabled due to fetching. Here

shalvah commented 5 years ago

Thanks @oneEyedSunday