search

shalvah / oldtweets.today

"On This Day" for Twitter #TwitterThrowback
http://oldtweets.today
113 stars 24 forks source link

Fixed issue #4 #7

Closed Lekky71 closed 5 years ago

Lekky71 commented 5 years ago

The share button creates a tweet intent, it has another tweet template text incase winder.username does not exist. I am yet to implement the automatic loading of results when someone clicks on the link, will do asap, add as an update feature.

Lekky71 commented 5 years ago
screen shot 2019-02-16 at 5 31 00 pm
shalvah commented 5 years ago

Let's leave the auto loading for a separate PR. One PR per feature.

Lekky71 commented 5 years ago

@shalvah I have made all required changes.

shalvah commented 5 years ago

I'd actually have preferred the button to have a text label, but I guess there isn't really good space on the interface.

BolajiAyodeji commented 5 years ago

How about a twitter icon? Should clearly state twitter sharing

Lekky71 commented 5 years ago

I'd actually have preferred the button to have a text label, but I guess there isn't really good space on the interface.

Yes, my thought too.

shalvah commented 5 years ago

Yes, I think a Twitter icon would be better. The current icon is still confusing to some folks. Plus, iOS uses a different icon, and Android, too, in some places.

Lekky71 commented 5 years ago

@shalvah done, I also changed the share icon.

shalvah commented 5 years ago

Thanks. Good work.

Lekky71 commented 5 years ago

Thanks