search

shalzz / zola-deploy-action

Github action for building a Zola site and deploying to Github Pages
MIT License
234 stars 91 forks source link

And fences highlight #88

Closed williamdes closed 2 months ago

williamdes commented 2 months ago

Hello @shalzz What do you think about this small change ?

shalzz commented 2 months ago

Hi, this looks like a more fine grained permissions control, which is fine if you want to have it in your own workflow. In the example I want to keep it simple for people using the action.

It's reasonable for them to go through the settings to enable write permissions. Something people overlook is that you need to know how to use github actions before you try an actual action. I cannot replicate the whole GH actions manual/documentation here.

williamdes commented 2 months ago

Hi, this looks like a more fine grained permissions control, which is fine if you want to have it in your own workflow. In the example I want to keep it simple for people using the action.

It's reasonable for them to go through the settings to enable write permissions. Something people overlook is that you need to know how to use github actions before you try an actual action. I cannot replicate the whole GH actions manual/documentation here.

Okay, I understand this. I removed the permissions changes, the PR should be okay now ?

shalzz commented 2 months ago

Yes, thanks and merged.