search

shama / base-element

:beginner: An element authoring library for creating standalone and performant elements.
81 stars 7 forks source link

Allow PRs to be tested on Travis #11

Closed bendrucker closed 9 years ago

bendrucker commented 9 years ago

Travis encrypted env vars are excluded from PRs so instead we install electron and test locally

bendrucker commented 9 years ago

So Electron won't run on Travis. Duh.

And Phantom's the worst. It's implementation of DOM input events is so badly borked that I'm not even sure it's possible to get browser-test-helpers working with it. Oh well.

shama commented 9 years ago

Yep this would be cool. Here is a related issue for PR support with sauce labs: https://github.com/travis-ci/travis-core/pull/418#issuecomment-95410197 and a discussion around it: https://support.saucelabs.com/entries/25614798-How-can-we-set-up-an-open-source-account-that-runs-tests-on-people-s-pull-requests-

bendrucker commented 9 years ago

Whoa, didn't realize that they were working on that. Sweet!