updated to latest npm node-globule, non-breaking change

shama / gaze

:crystal_ball: A globbing fs.watch wrapper built from the best parts of other fine watch libs.

MIT License

1.15k stars 168 forks source link

updated to latest npm node-globule, non-breaking change #208

Closed bradchesney79 closed 8 years ago

bradchesney79 commented 8 years ago

brad@E530:~/Desktop/gaze$ grunt nodeunit Running "nodeunit:files" (nodeunit) task Testing add_test.js...OK Testing api_test.js.....OK Testing patterns_test.js.OK Testing matching_test.js......OK Testing relative_test.js.OK Testing rename_test.js.OK Testing safewrite_test.js.OK Testing watch_test.js...............OK Testing watch_race_test.js.OK

59 assertions passed (34800ms)

Done, without errors.

shama commented 8 years ago

Here is everything that changed in globule from 0.1.0 to 0.2.0 which includes a major version bump on lodash and minor version bump on glob.

Bumping a patch version here on gaze to 0.5.3 would be disingenuous. Especially because it is really only to avoid an inconsequential deprecation warning message. If you really want to help contribute to this project, please try out this branch and investigate issues.

bradchesney79 commented 8 years ago

Testing with TravisCI additionally did reveal that node 0.8 breaks anyway. https://travis-ci.org/bradchesney79/gaze (similar to https://travis-ci.org/shama/gaze/jobs/99052665 ) -- I was actually trying to help out node-sass, which eventually calls gaze and ultimately lodash. But, it is your call and I won't give you any crap about it. Furthermore, thanks for the work that makes it function as well as it does in its current state.