shama / gaze

:crystal_ball: A globbing fs.watch wrapper built from the best parts of other fine watch libs.
MIT License
1.15k stars 168 forks source link

Remove global grunt-cli install from travis config #256

Closed Krinkle closed 5 years ago

Krinkle commented 5 years ago

"grunt-cli" is specified as a dev dependency in package.json. All commands exported by (dev)dependencies are available via the local node_modules/.bin directory, which is part of the PATH list for the context used for "npm test".

Developers already experience this locally, when they run npm install && npm test without installing Grunt globally. This has the added benefit of allowing you to control which Grunt version is used for this project.

Removing the redundant entry from travis.yml makes sure that CI tests use the same version as for local development, and prevents accidentally using a newer version that might be incompatible, which would result in an unrelated commit experiencing a build failure.

Documentation: https://docs.npmjs.com/misc/scripts#environment

shama commented 5 years ago

Thanks!