shama / letswritecode

:mortar_board: code examples for Let's Write Code
https://www.youtube.com/user/kylerobinsonyoung
804 stars 759 forks source link

App Process #19

Closed elbiber closed 6 years ago

elbiber commented 6 years ago

Hi,

I had errors after running "npm run build" the second time after testing the ".exe" file of the application in the dist/win-unpacked folder. I tried to delete the whole project folder to set it up from scratch again but this was not possible. So there was still something running it that folder. Only after restarting my computer i could run "npm run build" again. I wasn't able to find the process in the task manager so i used "Process Explorer". There i saw that the process of the app was still running in the background even the window was closed. After adding the function "window.on('close',.....app.quit()...." the main/index.js file the issue was solved. I don't know if this is a generall problem but on my machine it was. I hope i could help. Im using Windows 10.

By the way thanks for the great tutorial for this framework.

Regards Willy

shama commented 6 years ago

Thanks for the fix!

elbiber commented 6 years ago

You're welcome!