Prevent different git references from being cached under the same folder

shama / napa

:wine_glass: A helper for installing stuff without a package.json with npm.

MIT License

412 stars 34 forks source link

Prevent different git references from being cached under the same folder #29

Closed tomek-he-him closed 9 years ago

tomek-he-him commented 9 years ago

Hello,

When installing packages from git://…#tag urls, you can't update the the package without manually clearing the cache – the cached path doesn't take the reference into account.

I've created a pull request for npm-cache-filename as well.

Cheers

shama commented 9 years ago

Thanks for the PR. I'd rather wait until your PR on npm-cache-filename lands before tagging a dep to a fork on github.

tomek-he-him commented 9 years ago

The last commit is a quick-n-dirty attempt to solve #31. This works by brutally uninstalling the previously installed version of every package.

I'm sure you have another idea about how this should work. I'll be happy to help you do it right when I have a while.

Sorry for filing this here – I guess this should belong to another PR. I'm new to GitHub.

tomek-he-him commented 9 years ago

Ok, I see I've done all this wrong. Too bad to submit a PR from the master branch. I'm closing now to rewind and do it again.