Open tomek-he-him opened 9 years ago
+1
Just as a general thought as I am going through the code and the issue.
I am wondering if napa should wrap around npm libs instead. E.g. after code is downloaded, inject a package.json
somewhere and then let the npm libs carry on with the rest. Seems like a lot of work is duplicated inside napa where code exists in npm.
I'm seeing what I think is this same issue. Here is an example test repo with two commits: https://github.com/tschaub/test-napa. The first and second commits refer to different git URLs for a napa
dependency. If you check out the first commit, npm install
, and then check out the second commit, npm install
doesn't update the dependency as expected.
@tomekwi was #43 supposed to address this?
When you change a npm dependency's reference in package.json, it automatically gets uninstalled, and the new version gets downloaded and installed.
In napa you have to uninstall manually, take care of the cache (see my pull request), then reinstall. It would be über-cool if updating a napa dependency worked as seamlessly as updating an npm dependency.