shama / napa

:wine_glass: A helper for installing stuff without a package.json with npm.
MIT License
412 stars 34 forks source link

Update "download" module version #36

Closed msieurtoph closed 9 years ago

msieurtoph commented 9 years ago

Fixing the installation with url like : "http://localhost:xxxx/*_/_.zip"

shama commented 9 years ago

Thanks for the PR! Could you update the range to >=3.1.0 <3.2.0-0?

I prefer explicit version ranges as the spec for npm's ^ can (and has before) changed it's meaning. Also ^3.2.0 is semantically correct but the community doesn't always follow suit. It is common for authors to publish breaking changes on minor versions due to old habits that ~ set for people.

See https://github.com/rvagg/npm-explicit-deps for more reasons. Thanks!

msieurtoph commented 9 years ago

Done! ;)

shama commented 9 years ago

Thanks!

msieurtoph commented 9 years ago

Thx to you for having done that quickly.