Give different git references different folders

[tomek-he-him]

Hello,

When installing packages from git://…#tag urls, you can't update the the package without manually clearing the cache – the cached path doesn't take the reference into account.

I've created a pull request for npm-cache-filename as well.

Cheers

[till]

@tomekwi Neat. Any idea what is missing to get this in?

[tomek-he-him]

Hmm, as far as I can remember, existing tests just hung up on my machine. So I didn’t write an explicit test for that. Otherwise all was ready to merge.

@shama is doesn’t look like @npm is going to do anything about https://github.com/npm/npm-cache-filename/pull/1#issuecomment-70386513. If you’re open to changing the dep, I’ll try to find some time to write a test.

[shama]

@tomekwi Would you mind updating and rebasing that PR on npm/npm-cache-filename to just the necessary changes (current it has changes for napa-cache-filename)? That way if someone from @npm does look they'll be more inclined to merge. Then I'll ping them again. Thanks!

[tomek-he-him]

No problem. I’ll do it as soon as I find the time – perhaps I’ll even manage today (european).

[tomek-he-him]

@shama https://github.com/npm/npm-cache-filename/pull/2#issue-73140972

[shama]

Thanks!

[shama]

Closing as this was fixed with npm-cache-filename v1.0.2. Thanks again for your help @tomekwi! I've added you as an owner to this project. I really appreciate your help.

[tomek-he-him]

:+1: Thanks a lot! That’s an honor to me!

[tschaub]

Based on this and npm/npm-cache-filename#2, I'm guessing that it should work to update the hash in a git URL and have the dependency updated on the next napa run. I'm not seeing this happen, and before digging further, I wanted to check on the expected behavior.

[shama]

@tschaub It should cache per hash now. Let us know if it doesn't.

[tschaub]

@shama maybe user error, but here is a description of what looks like a problem to me: https://github.com/tschaub/test-napa/blob/master/readme.md