search

shama / on-load

On load/unload events for DOM elements using a MutationObserver
113 stars 19 forks source link

change browser aliasing to be more explicit #36

Closed DeMoorJasper closed 6 years ago

DeMoorJasper commented 6 years ago

Related to an issue encountered by a user of parcel: https://github.com/parcel-bundler/parcel/issues/1631

bcomnes commented 6 years ago

Tests are failing for some reason. Will have to dig in before merging.

lachenmayer commented 6 years ago

Hey @bcomnes :) The tests for on-load are actually all passing (20/20), the error in the CI stems from testron. In fact all of the previous releases I've tried out (back to v3.2.0) have the same error. I've written a fix for it here https://github.com/shama/testron/pull/8 Would really appreciate if you merged this, as it's currently stopping me from using nanocomponent in a project that could really use it. Thanks! :)

bcomnes commented 6 years ago

Ok perfect. Yeah, will cut a release asap today.

bcomnes commented 6 years ago

🎉on-load@3.4.1🎉