shama / yo-yoify

Transform choo, yo-yo or bel template strings into pure and fast document calls
111 stars 17 forks source link

Avoid template strings to support node 0.10 as a build platform #25

Closed phated closed 7 years ago

phated commented 8 years ago

I think this is a pretty simple change and lets this transform run in node 0.10+

Ran into this when trying to optimize some code on node 0.10.x

shama commented 7 years ago

Sorry looks like I forgot about this PR. I think I'd rather just convert the template literals to strings instead if Node 0.10 support is needed.

phated commented 7 years ago

Cool. Should I update this PR or send a new one?

shama commented 7 years ago

Oh if you wanted to update this PR that would be awesome. Thanks!

phated commented 7 years ago

@shama updated! I ran the babel transform against the index and test files and copied the relevant lines over (removing the semicolons). Tests should be passing. Thanks!

shama commented 7 years ago

Cool! Thanks a bunch!