search

shama / yo-yoify

Transform choo, yo-yo or bel template strings into pure and fast document calls
111 stars 17 forks source link

relative path in appendChild #51

Open kristoferjoseph opened 7 years ago

kristoferjoseph commented 7 years ago

Hey there, Been using yo-yoify for a time without issue, but just ran into an interesting one while trying to partition my bundles and CDN them.

Issue

my bundled file has a relative path to my computer in the require for appendChild

Actual

var ac = require('/Users/drippyorifice/Documents/example/node_modules/yo-yoify/lib/appendChild.js')

Expected

var ac = require('/node_modules/yo-yoify/lib/appendChild.js')

Wondering if it might be better to split appendChild into it's own module so that require will just work.

Thoughts?

yoshuawuyts commented 7 years ago

Yeah, think this is reasonable (:

On Thu, Jul 27, 2017 at 9:54 PM kj notifications@github.com wrote:

Hey there, Been using yo-yoify for a time without issue, but just ran into an interesting one while trying to partition my bundles and CDN them. Issue

my bundled file has a relative path to my computer in the require for appendChild Actual

var ac = require('/Users/drippyorifice/Documents/example/node_modules/yo-yoify/lib/appendChild.js') Expected

var ac = require('/node_modules/yo-yoify/lib/appendChild.js')

Wondering if it might be better to split appendChild into it's own module so that require will just work.

Thoughts?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/shama/yo-yoify/issues/51, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWleoEG7aB7cuTithEnU_CeaklRl6_eks5sSOrpgaJpZM4Olwow .