shamanec / GADS

Simple device farm for remote control of devices and Appium test execution on iOS/Android
MIT License
74 stars 16 forks source link

Tap/Swipe actions are not working in application which operates in landscape mode as intended for iOS #121

Closed Gnanaprakash22 closed 2 months ago

Gnanaprakash22 commented 2 months ago

Click/Swipe actions are clicking at random places for application which operates in landscape mode. In portrait application actions are smooth.

Also if possible please handle the screen resolution/viewport in landscape mode for better usability :)

To provide more context it is an unity application

please let me know if you need further information

[Video Link]

shamanec commented 2 months ago

Yeah, that is expected because landscape is not handled at all :D This will require some work because it will be hard to automatically find out the current mode when you switch it on the device - I will look into it though, the easiest solution will probably be to add a button with which you will manually tell the UI that you are currently on landscape/portrait

Gnanaprakash22 commented 2 months ago

yes having a button for landscape/portrait works :)

shamanec commented 2 months ago

I'll create a release with this later today

shamanec commented 2 months ago

@Gnanaprakash22 v2.3.0. Let me know if something ain't right, also try to use your device landscape to your left(device right) :D

Gnanaprakash22 commented 2 months ago

@shamanec awesome !!! thanks will test it out

Gnanaprakash22 commented 2 months ago

@shamanec it is working fine but one lil problem the page is not responsive/scrollable to see Landscape/Portrait button

shamanec commented 2 months ago

I guess I have to reduce the responsive sizes even more, I am used to having a high resolution monitor and I forget about that 😅

Gnanaprakash22 commented 2 months ago

speed is slow when accessing remotely through other system using the hub link sometimes page refresh has to be done to see the new screen or the click action

shamanec commented 1 month ago

I don't think there is anything I can do about that as stated in the FAQ - I use WebDriverAgent for both the interaction and streaming so it is as good as they provide it. I might add an option to reduce the FPS and quality even more but I can't guarantee this will help over remote access :(

Gnanaprakash22 commented 1 month ago

@shamanec could you please implement long tap & drag and drop in landscape mode it is not working

shamanec commented 1 month ago

I'll check about the long tap but I can't make any promises on drag&drop - it doesn't exist right now, its not only on landscape

Gnanaprakash22 commented 1 month ago

I'll check about the long tap but I can't make any promises on drag&drop - it doesn't exist right now, its not only on landscape

swipe(horizontal/vertical) is also not working in landscape for the app(Unity application) which i was checking , also please make the page which is rendering the device screen scrollable to see portrait/landscape buttons

Kindly add these fixes and implementations in next release

shamanec commented 1 month ago

Do you think you can create some sample Unity app I can use for testing the swipe? I see no reason why swipes would work in some apps and not in others, I am just using coordinates :|

Gnanaprakash22 commented 1 month ago

please share me your gmail id

shamanec commented 1 month ago

tapanar6@gmail.com

Gnanaprakash22 commented 1 month ago

shared please check

shamanec commented 1 month ago

The buttons are now moved to the right of the stream canvas so this should be fine - I will need more time to go over the tap/swipe actions because it seems its more complex than I anticipated :)

shamanec commented 1 month ago

@Gnanaprakash22 you can check out the latest 2.4.1 release - swipe and tap should work better, also touch&hold. You still can't drag n drop though, or maybe you can if the element accepts swiping action

Gnanaprakash22 commented 1 month ago

sure thanks for the update @shamanec will check this

Gnanaprakash22 commented 2 weeks ago

@shamanec swipe and tap works better in this build thanks