shamansim / Vizection

Shiny application for single cell transcriptomics studies data visualisation / exploration and quality control
0 stars 2 forks source link

Move functions from server.R to package proper #11

Closed charles-plessy closed 7 years ago

charles-plessy commented 7 years ago

Hi Simon,

in order to "reproduce" in the command line some analyses made with the Shiny interface, I tried to transfer some functions from the server.R file to the package itself, that is, the files under the R directory.

The main difficulty was that in server.R the functions were wrapped in reactive blocks, with step-by-step executions to have nice progress bars. Importantly, I wanted to ensure that it is exactly the same command that would be run in command-line or in Shiny, so I did not just make simplified copies of the functions. Rather than going deep in the details, perhaps you will quickly get the point by looking at the commits below.

Do you think that the approach makes sense ?

Have a nice day,

-- Charles

shamansim commented 7 years ago

Hi Charles,

I think this is a great idea. Vizection becomes modular:

Also you simplified a lot the functions. Thank you! We should definitely continue to develop in this direction. (Sorry for not being very productive for vizection during the last months).

Have a nice day too,


Simon