search

shamansystems / Cheap-FOCer-2

Low-Cost Motor Controller based on the VESC 6
331 stars 77 forks source link

Bj changes #1

Closed bj97301 closed 4 years ago

bj97301 commented 4 years ago

@shamansystems please review

Mitchlol commented 4 years ago

Looks like you scaled up the 22uh inductor from 5 to 25 for the 5x bom, but it was only 5 to meet the minimum quantity. So it should still be 5 on the 5x bom.

Also in the markdown guide some of the lcsc images are for 1x and some for 5x.

bj97301 commented 4 years ago

Ah yes. Would you be able to update the csv with the correct quantities for 5x? I can update the images first thing tomorrow.

On Sat, Apr 18, 2020 at 10:11 PM Mitch Lustig notifications@github.com wrote:

Looks like you scaled up the 22uh inductor from 5 to 25 for the 5x bom, but it was only 5 to meet the minimum quantity. So it should still be 5 on the 5x bom.

Also in the markdown guide some of the lcsc images are for 1x and some for 5x.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/shamansystems/Cheap-FOCer-2/pull/1#issuecomment-616034955, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALCDP4KEW3WRNE4K5MQ24LRNKBYPANCNFSM4MLP5ULQ .

Mitchlol commented 4 years ago

LCSC X5 bom doesnt have BMI160 & USB port, not sure what else.

is everything in blue on the original BOM meant to be from lcsc?

Mitchlol commented 4 years ago

Facing some confusion about the proper mosfet.

the 5xbom has SE60210GA the regular bom has NCEP60T20

and the ordering guide says these are alternates NCEP60T20 SE80160GA20

Mitchlol commented 4 years ago

One other thing that threw me off at first was the list of missing components that i download from JLCPCB i wasn't sure if i needed to buy them for LCSC or what to do with it after downloading. I got it figured out now, but to me that is an area that can use clarification.

shamansystems commented 4 years ago

Ah yes I need to add the BMI160 and the USB to the BOM. The SE60210GA seems to be restocked more often than the NCEP60T20 but either MOSFET are relatively equivalent to each other.

shamansystems commented 4 years ago

Mitchlol I try to explain what the "unselected parts list" does in the guide

"Scroll down and you will see a list of Unselected Parts. If all parts were available based on this guide so far, then the LCSC BOM later in this guide covers the remainder of the parts. If you excluded certain parts on your own or if JLCPCB was out of stock of something, then I advise selecting the “Download Unselected Parts List”. This will then be a list of what you still need to acquire external to JLCPCB"

Could this be explained or worded better?

bj97301 commented 4 years ago

BMI160

added bmi and a note about it being optional and requiring a reflow station

bj97301 commented 4 years ago

USB

@shamansystems Any suggestions regarding the USB port? Thoughts on using a usb-c port?

Mitchlol commented 4 years ago

Mitchlol I try to explain what the "unselected parts list" does in the guide

"Scroll down and you will see a list of Unselected Parts. If all parts were available based on this guide so far, then the LCSC BOM later in this guide covers the remainder of the parts. If you excluded certain parts on your own or if JLCPCB was out of stock of something, then I advise selecting the “Download Unselected Parts List”. This will then be a list of what you still need to acquire external to JLCPCB"

Could this be explained or worded better?

Interesting, I see this now, not sure how i missed it yesterday, I think I was starting to skim directions by this point. But in my defense there is some confusing terminology.

"the LCSC BOM later in this guide covers the remainder of the parts" <-- is that including these or the remaining parts excluding these.

"This will then be a list of what you still need to acquire external to JLCPCB" <-- this is a partial list that has duplicates with some items on the lcsc bom.

So here is my stab at rewriting it.

Step 16 Missing Parts: If your red "No part selected" list in step 13 matched up with this guide, you can skip this step, as these parts are included in the LCSC BOM (it includes these parts as well as others). However if you excluded certain parts on your own, or if JLCPCB was out of stock of something, then I advise selecting the “Download Unselected Parts List”. This will then be a list of what you still need to acquire external to JLCPCB (The parts listed as "No part selected" in this guide will be duplicated in "Unselected Parts List" and "LCSC BOM", but you only need one set)

I think step 13 should also have a note if parts are missing see step 16

bj97301 commented 4 years ago

Missing Parts: If your red "No part selected" list in step 13 matched up with this guide, you can skip this step, as these parts are included in the LCSC BOM (it includes these parts as well as others). However if you excluded certain parts on your own, or if JLCPCB was out of stock of something, then I advise selecting the “Download Unselected Parts List”. This will then be a list of what you still need to acquire external to JLCPCB (The parts listed as "No part selected" in this guide will be duplicated in "Unselected Parts List" and "LCSC BOM", but you only need one set)

Good feedback. Take a look at what I just pushed and let me know if its easier to understand.

bj97301 commented 4 years ago

@shamansystems Do you have a part number for the usb port? I was hoping to add it to one of the bom files. Would jlcpcb put it on the board for us?

bj97301 commented 4 years ago

Oh wait i found it in the `

@shamansystems Do you have a part number for the usb port? I was hoping to add it to one of the bom files. Would jlcpcb put it on the board for us?

actually found it C145795 in the bom.csv

Mitchlol commented 4 years ago

Missing Parts: If your red "No part selected" list in step 13 matched up with this guide, you can skip this step, as these parts are included in the LCSC BOM (it includes these parts as well as others). However if you excluded certain parts on your own, or if JLCPCB was out of stock of something, then I advise selecting the “Download Unselected Parts List”. This will then be a list of what you still need to acquire external to JLCPCB (The parts listed as "No part selected" in this guide will be duplicated in "Unselected Parts List" and "LCSC BOM", but you only need one set)

Good feedback. Take a look at what I just pushed and let me know if its easier to understand.

Looks good to me, says the same thing with much less words. Only thing that come to mind is that "Unselected Parts List" will have duplicates with LCSC BOM but I'm sure people will figure it out.

Also some steps have remaining text after an image, i think hasty readers may miss text after images, and skip to the next step. Or see that their image doesn't match, and not think to read below the image.

shamansystems commented 4 years ago

BMI160: C94021

Micro USB: C145795

I'm using USB C for the Little FOCer but not for the CFOC2. Through-hole versions of Micro USB can be found which is much better for DIY. All the USB C receptacles are surface mount. JLCPCB doesn't have any usb receptacles in their SMT library.

bj97301 commented 4 years ago

I see. 👍🏿

On Mon, Apr 20, 2020 at 5:41 AM shamansystems notifications@github.com wrote:

BMI160: C94021

Micro USB: C145795

I'm using USB C for the Little FOCer but not for the CFOC2. Through-hole versions of Micro USB can be found which is much better for DIY. All the USB C receptacles are surface mount. JLCPCB doesn't have any usb receptacles in their SMT library.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/shamansystems/Cheap-FOCer-2/pull/1#issuecomment-616527162, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALCDPYNNXWFRIHA3DUJJLDRNQ7I7ANCNFSM4MLP5ULQ .