allow byte strings in map keys

shamblett / cbor

A CBOR implementation for Dart

MIT License

36 stars 16 forks source link

allow byte strings in map keys #24

Closed reaster closed 3 years ago

reaster commented 3 years ago

I modified the cobra_encoder to process byte strings and included a test. I'm not sure about json support but I'm happy to collaborate if an issue is identified. Cardano transactions require byte string keys and I've verified deeply nested encoding and decoding output against https://github.com/c-rack/cbor-java library using https://cbor.me.

shamblett commented 3 years ago

Ok thanks I'll have a look at this.

shamblett commented 3 years ago

One thing, I'm not keen on putting the .vscode files in the repo, I want to not check in IDE specific stuff. I use Intellij Idea, this too has its own IDE files but these are ignored in .gitignore. I understand that a lot of devs use VSCode for Dart development, if there really is a need for this I'll live with it but I'd rather not.

reaster commented 3 years ago

Agreed. IDE artifacts should not be there. My mistake.