Fix issue 103, improve validation

JosefWN commented 2 years ago

addUriPath appends a single path to the full path, uriPath sets the path as a whole. Since addUriPath is a bit less idiomatic to use when setting the full path I have removed that use from the examples (and by mistake in the CoapClient as well, the root cause for the bug in #103).
Setting the uri (internal setter) would because of my re-write override the uriPath with that of the URI (blank), removed this since it's the base URI that's actually set (host/port).
Removed some nullables where the function would throw an error if the value was null.
Made properties symmetric, i.e. locationPath setter and getter both return the same thing (almost, sanitized input), rather than setting locationPath and getting the same value from locationPathsString.
Removed nearly duplicate properties (uriPath vs uriPathsString).
Improved input validation (for example uri path length check only took place on addUriPath, but not when setting uriPath). Added tests to cover edge cases.

shamblett commented 2 years ago

I wasn't sure if this was ready, so I merged the others, this has now resulted in a conflict.

JosefWN commented 2 years ago

Rebased, added a couple more test cases and re-ran all examples except the DTLS ones and they looked OK.

I'm fine with merging this if you guys are.

shamblett / coap