search

shamblett / coap

A Coap package for dart
Other
16 stars 13 forks source link

Rework option system #122

Closed JKRhb closed 1 year ago

JKRhb commented 2 years ago

I am currently working on an overhaul of the option implementation. This PR is still WIP but I already wanted to share my progress with you.

shamblett commented 2 years ago

Just to hijack this slightly are we now good to go for a 5.0.0 release, there's been a lot put in since 4.2.1

JKRhb commented 2 years ago

Just to hijack this slightly are we now good to go for a 5.0.0 release, there's been a lot put in since 4.2.1

Oh, yeah, sorry, I think we can go forward with a 5.0.0 release :) Although I made some good progress here already, this PR is probably something for the next major release (after 5.0.0).

JKRhb commented 2 years ago

I think this PR would now be ready for an initial review (CC @JosefWN). If you think the PR is close to being mergeable, we could include it in the 5.0.0 release. As mentioned above, we could also include it in a later release.

JKRhb commented 2 years ago

Applied a couple of further improvements, making options actually immutable and providing a very basic OSCORE option implementation. I think there is still some more work to be done, so I would definitely postpone this after the 5.0.0 release.

shamblett commented 2 years ago

Ok will do Ive targetted the 5.0.0 release for this Friday

JKRhb commented 2 years ago

Ok will do Ive targetted the 5.0.0 release for this Friday

Okay, great :)

JKRhb commented 2 years ago

Performed some more cleanup and resolved a few remaining issues. I think this PR should now be ready for another (final?) review :)

JKRhb commented 1 year ago

Rebased the PR and provided a couple of additional test cases for invalid option formats.

JKRhb commented 1 year ago

Added a last minute fix for the encoding of the OSCORE option.

JKRhb commented 1 year ago

Rebased the PR against the latest upstream version. Now it should finally be ready to be merged :)

JKRhb commented 1 year ago

Noticed an issue with the endianness of the integer option again... Should be fixed now. I am applying a couple of last changes, then this should actually be ready to be merged.

JKRhb commented 1 year ago

I now also included a rework of the observe (de)registration values for requests in f9ea52f, resolving the last item from the checklist in #80.