search

shamblett / coap

A Coap package for dart
Other
16 stars 13 forks source link

feat: add constructors and client methods for new CoAP methods #123

Closed JKRhb closed 1 year ago

JKRhb commented 1 year ago

This is a relatively simple PR that adds support for the newly defined FETCH, PATCH, and iPATCH methods to the CoapClient and CoapRequest classes. It could be included in the 5.0.0 release but we might as well integrate it in 5.1.0.

CC @JosefWN

JosefWN commented 1 year ago

LGTM

JKRhb commented 1 year ago

@shamblett Do you think this could be merged? Or do you see anything that should be changed here?

shamblett commented 1 year ago

Hi, Im on hols at the mo and so dont have my dev environment available I can however merge stuff so if you guys think something is ready please update the PR and Ill press the buttons.

I wont be back in action gill around 30th September

shamblett commented 1 year ago

Hi all, OK back in action, this looks OK to me, if no other shouts I'll merge it.

JKRhb commented 1 year ago

Hi all, OK back in action

Welcome back!

this looks OK to me, if no other shouts I'll merge it.

That would be great, thank you :)