search

shamblett / coap

A Coap package for dart
Other
16 stars 13 forks source link

feat!: make client config optional #128

Closed JKRhb closed 1 year ago

JKRhb commented 2 years ago

In many scenarios, I got the impression that mandating the user to specify a custom config for each client is not really necessary. Instead, using the default config is actually fine in many cases and makes the library easier to handle if you need to create many requests to different endpoints at different places in your code.

Therefore, this PR proposes making the config parameter on the client optional, using the default config if the user did not supply one. This PR has the downside of creating a breaking API change, so it should probably only be merged before the release of version 6.0.0.

shamblett commented 1 year ago

This looks OK to me, I'll merge if you are happy.

JKRhb commented 1 year ago

Awesome, feel free to merge :)