search

shamblett / coap

A Coap package for dart
Other
16 stars 13 forks source link

Address Todos #142

Closed JKRhb closed 1 year ago

JKRhb commented 1 year ago

This PR addresses some of the TODOs mentioned in #140 and a couple of minor linting issues.

As part of this PR, the isPrintable method is removed from the CoapMediaType enum as it did not fulfill a real purpose IMHO.

JKRhb commented 1 year ago

Covered two more TODOs with the latest commits.

JKRhb commented 1 year ago

@shamblett Did you maybe have the chance to have a look on this PR and https://github.com/shamblett/coap/pull/141 yet?

shamblett commented 1 year ago

OK, they look OK to me, I'll merge them if you agree.

JKRhb commented 1 year ago

OK, they look OK to me, I'll merge them if you agree.

Sure, that would be great :)