search

shamblett / coap

A Coap package for dart
Other
16 stars 13 forks source link

fix: apply proper percent encoding to URI options #157

Closed JKRhb closed 1 year ago

JKRhb commented 1 year ago

This PR applies some fixes to the URI options (regarding percent-encoding) and resolves a problem with the String option encoding.

It also resolves a couple of TODOs from #142.

shamblett commented 1 year ago

If your happy this is complete I'll merge it

JKRhb commented 1 year ago

Thank you, @shamblett! I applied a couple of additional refactorings/fixes to this PR – I think this one and #158 should now be ready to be merged :)

JKRhb commented 1 year ago

(Ahem, sorry, I applied one more minor change. Now the PRs should be ready 🙂)