search

shamblett / coap

A Coap package for dart
Other
16 stars 13 forks source link

Fix every first request failure #30

Closed a1573595 closed 2 years ago

a1573595 commented 2 years ago

Hi, thank your sample, I found some bug and try to fix it, hop it can help.

  1. Socket binding is asynchronous, you should use await to ensure that the initialization is completed before the request.
  2. Use CoapNetworkUDP to avoid generation CoapNetworkUDP again.

28

a1573595 commented 2 years ago

Sorry for that, I am working on windows, some path setting is different.

shamblett commented 2 years ago

Thanks for this, its much better, merged on PR #31

a1573595 commented 2 years ago

If you think I modified something that shouldn't be changed, you can tell me directly. I will close it and submit new pull. Don't erase my contribution, I won’t help anymore.

shamblett commented 2 years ago

No you didnt do anything wrong, when I changed the merge base to my issue28 branch I reviewed the code which was ok but forgot to merge it, s when I merged the branch your code wasn't in it so I creted a nee branch, manually added yor changes and merged it.

This was my fault not yours. Thanks again.