search

shamblett / coap

A Coap package for dart
Other
16 stars 13 forks source link

fix: apply fixes to basic multicast scenario #61

Closed JKRhb closed 2 years ago

JKRhb commented 2 years ago

This PR applies a couple of fixes/changes to the project in order to make it possible to use simple (i. e. non-blockwise) multicast requests. To achieve this, multicast requests are no longer being able to be sent as confirmable messages (c. f. RFC 7252, section 8.1). Instead, all confirmable multicasts requests are converted to non-confirmable ones. Furthermore, multicast requests are no longer being labelled as complete after the first response and multiple responses no longer marked as duplicates.

I guess the solution is probably not perfect yet (and does not resolve #55 yet), but I guess it is a step into the right direction. Feedback is highly appreciated :)

shamblett commented 2 years ago

OM I've merged some of your earlier PR's and re released the package at version 3.4.1. I'll look at this in relation to #55 hopeully shortly.

shamblett commented 2 years ago

Nothing strikes me as being odd here but I guess that eventually we will have to go with something and get feedback as to actual behavior by testing, its a difficult area to work in.

It almost looks as though we need a special multicast endpoint maybe, rather than varying the behavior of the general one then of course we would have to instantiate when needed which may be problematic in itself.

Lets see where we go with the changes so far.

JKRhb commented 2 years ago

It almost looks as though we need a special multicast endpoint maybe, rather than varying the behavior of the general one then of course we would have to instantiate when needed which may be problematic in itself.

That is a good idea! This might also make it easier to deal with the blockwise case. I will try it out in the context of #56.