search

shamblett / coap

A Coap package for dart
Other
16 stars 13 forks source link

Stricter linting #95

Closed JosefWN closed 2 years ago

JosefWN commented 2 years ago

An attempt at fixing https://github.com/shamblett/coap/issues/77, we can make the config more relaxed as part of this PR if we want, this is just a fairly strict suggestion/starting point for discussions.

There are a bunch of things the default/recommended lint configs don't catch, mostly because there is no consensus on whether to lint in way A or way B for a given issue, so the recommendations boil down to neither (where it could be better to just choose A or B for consistency).

Relaxed the validation a little in the config builder, for example it now requires correct input on bools (strings will not pass as bools even if they are "true" or "false") and the dtlsBackend, they will know if they get it wrong anyway at compile time?

shamblett commented 2 years ago

Looks OK to me, I can merge this if we are agreed, also we should be thinking of re releasing the package at this point, quite a bit ahs gone in since the last release.

shamblett commented 2 years ago

OK merged, all the analysis errors have now gone, thanks.