shamblett / mqtt5_client

A server and browser based MQTT 5 client for dart
Other
49 stars 25 forks source link

issue77: Fixed the invalid range error issue with the small matchee raw topic when compared with base raw topic length #78

Closed ashu-pietech closed 6 months ago

ashu-pietech commented 8 months ago

Added another condition to check if matchee topic's fragments length is less than the length of base topic's fragment. Currently there's only one condition to handle the opposite condition such as if base topic's fragment length is less than matchee fragment length

shamblett commented 8 months ago

Ok, the file mqtt_client_base_test.dart contains a group test ''Subscription Topic' to unit test this class, could you add a test/s to test your change please.

ashu-pietech commented 8 months ago

Ok, the file mqtt_client_base_test.dart contains a group test ''Subscription Topic' to unit test this class, could you add a test/s to test your change please.

Sure I'll check that

shamblett commented 8 months ago

Re released the package for issue 79, you will probably need to rebase.

ashu-pietech commented 7 months ago

@shamblett I've updated the PR after rebase

shamblett commented 7 months ago

OK an existing unit test is now failing, could you have a look please, thanks.

ashu-pietech commented 7 months ago

OK an existing unit test is now failing, could you have a look please, thanks.

Okay I'll check it

ashu-pietech commented 6 months ago

@shamblett PR updated and now all the test cases are working

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0f8e103) 61.23% compared to head (ff1f241) 61.18%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #78 +/- ## ========================================== - Coverage 61.23% 61.18% -0.06% ========================================== Files 102 102 Lines 3555 3558 +3 ========================================== Hits 2177 2177 - Misses 1378 1381 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.