Closed ashu-pietech closed 6 months ago
Ok, the file mqtt_client_base_test.dart contains a group test ''Subscription Topic' to unit test this class, could you add a test/s to test your change please.
Ok, the file mqtt_client_base_test.dart contains a group test ''Subscription Topic' to unit test this class, could you add a test/s to test your change please.
Sure I'll check that
Re released the package for issue 79, you will probably need to rebase.
@shamblett I've updated the PR after rebase
OK an existing unit test is now failing, could you have a look please, thanks.
OK an existing unit test is now failing, could you have a look please, thanks.
Okay I'll check it
@shamblett PR updated and now all the test cases are working
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
0f8e103
) 61.23% compared to head (ff1f241
) 61.18%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Added another condition to check if matchee topic's fragments length is less than the length of base topic's fragment. Currently there's only one condition to handle the opposite condition such as if base topic's fragment length is less than matchee fragment length