search

shamblett / mqtt5_client

A server and browser based MQTT 5 client for dart
Other
49 stars 25 forks source link

fix(lib/mqtt5_browser_client): switch dart:html to universal_html #86

Closed deepanchal closed 6 months ago

deepanchal commented 6 months ago

Port over change from https://github.com/shamblett/mqtt_client/commit/d7eec87d5f151e09d006fab73a68346202d31719

Closes #85

deepanchal commented 6 months ago

Hi @shamblett Could you please review these changes at your convenience? These changes are relatively straightforward and shouldn't take much of your time to review. Thanks!!

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (de489b5) 61.18% compared to head (a94d3e1) 61.18%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #86 +/- ## ======================================= Coverage 61.18% 61.18% ======================================= Files 102 102 Lines 3558 3558 ======================================= Hits 2177 2177 Misses 1381 1381 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shamblett commented 6 months ago

Yep merged, I'll look at re publishing the package in the next few days.