shamesjen / pe

0 stars 0 forks source link

Unclear Duplicate Detection with Spaces #3

Open shamesjen opened 4 months ago

shamesjen commented 4 months ago

image.png

Description

As shown in the image above, James Goh was added twice even though it is the same person. This is caused by an extra space in the second James Goh.

Steps to reproduce

  1. Launch the application
  2. Run the command 'addBuyer n/James Goh p/98765432 e/james@gmail.com budget/20000 type/Hdb'
  3. Run the command 'addBuyer n/James Goh p/98765432 e/james@gmail.com budget/20000 type/Hdb'
  4. Observe the list.

    Expected behaviour

    At step 3, output should return an error message saying that James Goh is a duplicate person.

    Actual behaviour

    At step 3, output successfully added James Goh

    Reason for severity

    This kinda of typo can be quite common when typing fast, however it is easily rectified by deleting the extra person.

    Ideas

    Perhaps trim each individual word in the name as well.

nus-se-script commented 4 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Infinite Spaces possible in Name

No full name has infinite spaces between names. For example "John Doe" is a valid name, but "John Doe" is not a realistic name. However, such a name is possible in the app


[original: nus-cs2103-AY2324S2/pe-interim#5542] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for pointing it out! Currently, our app does not handle the extra spaces between two words.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]