search

shamesjen / pe

0 stars 0 forks source link

Storage can't be fixed #8

Open shamesjen opened 5 months ago

shamesjen commented 5 months ago

https://youtu.be/pwKat0eXMhg

Description

After the file is deleted, when I edit the file with the corrected file, it still does not work.

Steps to reproduce

  1. Launch the application
  2. Break the storage so it is wiped.
  3. Launch the application
  4. Change the broken storage to a corrected version.
  5. Relaunch the application.

    Expected behaviour

    At step 5, output should be the corrected storage.

    Actual behaviour

    At step 5, output is still empty.

    Reason for severity

    Data Loss may be irreversible

soc-pe-bot commented 4 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

JSON Override does not work as specified in UG

The UG says, "EstateEase data are saved automatically as a JSON file [JAR file location]/data/addressbook.json Advanced users are welcome to update data directly by editing that data file."

It does not specify that any edits made while the application is open, will not take effect ever, which is the case.

To test, open the app with the default template, open the addressbook.json, delete a user. This change will be overridden on closing the app.

Medium severity as user may lose changes without knowing

[original: nus-cs2103-AY2324S2/pe-interim#4632] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for bringing this issue to our attention. Addressing this specific problem is currently considered as less important because the application is designed to display updated data whenever the application is opened, provided that any valid changes were made to the JSON file when the application is closed.

It is important to note that the functionality to check for the updated data in JSON does exist; however, the application does not prioritise validation of edits made to the JSON while the application is running concurrently in this current version.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]