search

shamiao / l4mysqlqueue

A laravel 4 queue driver using MySQL database, developed for small websites on shared hosting.
MIT License
9 stars 8 forks source link

ASCII collation #1

Open marcus-clements opened 9 years ago

marcus-clements commented 9 years ago

Why does it need to be ASCII collation? The mysql only command means I can't use sqlite in testing which is a shame.

thanks

Marcus

shamiao commented 9 years ago

A mistake was made. I simply don't understand why I wrote code like this a season ago...

createPayload() in Illuminate\Queue\Queue always calls json_encode() to generate a ASCII JSON format payload string. I may once thought that ASCII collation helps for avoiding any encoding troubles. But:

Considering using BLOB mades payload string unable to read directly in phpMyAdmin, I prefer creating table with native l4 schema builder, and change collation of payload column to ASCII only if database driver is MySQL.

Thank you for this issue :+1: , an upgrade is coming this week.