Review Project 1

[pkfl]

• [x] Readme.md - should tell a user, how to use your project easily, with sample usage code.
• [x] pylint for code needs improvment
• [x] requirements.txt file is missing
• [x] pytest - no tests!
• [x] All tests need to be in a directory called "tests"
• [x] Rename your repo to a new name - no uppercase or _ or - - For example "wordcolor"
• [x] This repo will then require the code to be in a directory called "wordcolor"
• [x] coverage => 100%
• [ ] Use sphinx to generate documentation for your code that would end up in "docs" directory
• [ ] docopt missing. Needs documentation.
• [x] Readme does not work on my machine (python3 color_mapping_main.py - throws an error)
• [x] Remember - no function should be more than 25 lines of code, and if name == "main" : should just call main()
• [x] aim for pylint score - 10/10 (I'm only looking at main/master branch)
• [x] Think on how you can speed up the process of converting "phrase" to color

[pkfl]

Can you increase the speed of your text->color converter and do it without going to a search engine?

[pkfl]

My coverage run -m pytest shows this. Did I miss something?

Name Stmts Miss Cover

tests/init.py 0 0 100% tests/image_processor_test.py 19 0 100% tests/stat_calculator_test.py 16 0 100% wordcolor/init.py 0 0 100% wordcolor/image_processor.py 124 94 24% wordcolor/stat_calculator.py 23 0 100%

TOTAL 182 94 48%

[pkfl]

Does this work for your problem?

https://github.com/lucidrains/deep-daze