shamirlabs / diva-alpha-net

Diva alpha testnet
https://docs.shamirlabs.org/diva/testnet/intro
19 stars 17 forks source link

Suggestion - use docker volumes to make data more portable and respect /etc/docker/daemon.json #19

Closed actuallymentor closed 1 year ago

actuallymentor commented 1 year ago

Currently the docker-compose files use direct file bindings.

Using docker volumes would make the stack respect the path setting in /etc/docker/daemon.json and make the management of volumes a bit easier.

This is the approach the RP smartnode stack takes.

yorickdowne commented 1 year ago

This can :100: work for consensus DB, execution DB, and diva DB. The way that validator shares its keymanager jwt with reloader right now is better suited to a bind mount, but that's a) a negligible amount of storage and b) if keen, could also be solved without bind mount and using a named volume.

yorickdowne commented 1 year ago

So this is now still a bind mount, but configurable as to where. Good enough?

actuallymentor commented 1 year ago

@yorickdowne it's good enough for me, but volumes are still a step up over the long term I think

yorickdowne commented 1 year ago

I agree. Volumes also make it possible to run diva as "not root", which is arguably better for security