search

shamirlabs / diva-alpha-net

Diva alpha testnet
https://docs.shamirlabs.org/diva/testnet/intro
19 stars 17 forks source link

Added DIVA_W3S_PORT to configure divad port #23

Closed PacoBits closed 1 year ago

PacoBits commented 1 year ago

By default, divad runs using port 9000. This port is used by most CLs as the default p2p port. This pull request aims to make it easier to configure the port that divad uses through the DIVA_W3S_PORT parameter.

yorickdowne commented 1 year ago

Another way to solve this is to just not host map this port. It’s the web3signer and doesn’t need to be accessible from anything but the validator service.

pradavc commented 1 year ago

We left the 9000 because it is the standard W3S port. It can be changed in the dockers at will, but as default, I think it is a good option. Any other opinion about pro or against 9000?

yorickdowne commented 1 year ago

It's a good default, it just "steps on" the P2P port of the CL when host-mapped to 127.0.0.1. Host-mapping it isn't required, it's just a dev convenience. Reducing host mappings across the board to just P2P ports would be a good QoL improvement. Devs can still add a dev-ports.yml to COMPOSE_FILE that brings the host mappings back.

If that approach has appeal, I'm happy to give you a PR for it.

yorickdowne commented 1 year ago

Created #31 as an alternate way to handle this

pradavc commented 1 year ago

Solved already in #31 . Closing this PR.