shamsdev / davinci

An esay-to-use image downloading and caching library for Unity
MIT License
290 stars 52 forks source link

Create a .editorconfig file #22

Closed Techie-Pi closed 3 years ago

Techie-Pi commented 3 years ago

After seeing the problems with #13 and #20 and the file changes that change nothing (probably end-of-line or something similar). It may be an interesting idea to create a .editorconfig file, a file supported by most IDEs without any plugin (Visual Studio, Rider, Visual Studio Code -with plugin-...) to specify the charset, indent size and style, etc of certain files.

There could be also a .gitattributes file, but that could interfere with Unity files. I'll check the current coding styles and create a PR, although maybe @shamsdev prefers to set himself the coding style to be used in the project instead of a contributor*.

shamsdev commented 3 years ago

Thank you very much @Techie-Pi, that would be great! Can you please create that files?

Techie-Pi commented 3 years ago

Yes, of course

Techie-Pi commented 3 years ago

For both .editorconfig and .gitattributes I'm going to follow the .NET code style rule options.

The pull request will contain the following changes:

shamsdev commented 3 years ago

Very nice! Thank you @Techie-Pi

Techie-Pi commented 3 years ago

You're welcome!

Techie-Pi commented 3 years ago

20 Closed, now #25

13 is going to be remade by me