Closed GoogleCodeExporter closed 9 years ago
[deleted comment]
I claim this task.
Original comment by andreas....@gmail.com
on 29 Nov 2007 at 8:25
Hi,
I posted a first patch to
http://bugzilla.gnome.org/show_bug.cgi?id=500782
awaiting feedback :)
Andreas Noever
Original comment by andreas....@gmail.com
on 1 Dec 2007 at 1:43
Original comment by jpo...@gmail.com
on 3 Dec 2007 at 5:52
Hi,
I did some more changes and this is the result (the patch is also on bugzilla).
This is my "completed" version. Please review it and contact me if there are any
problems.
Andreas Noever
Original comment by andreas....@gmail.com
on 6 Dec 2007 at 8:51
Attachments:
Original comment by shana.u...@gmail.com
on 7 Dec 2007 at 7:49
Hi,
how is the review going? Any feedback/comments?
Can I claim another task until the review is complete?
Andreas Noever
Original comment by andreas....@gmail.com
on 12 Dec 2007 at 9:26
Original comment by sdelcr...@gmail.com
on 13 Dec 2007 at 8:38
Andreas,
could you explain how to use that, what's the expected results and so on ?
I tried your patch, reauested a api-key for a particular folder on my website,
then
generated the gallery...
The index.html page looks exactly the same as before (no map, no geotagging
info),
and the f-spot-google-maps is empty.
my test gallery: www.delcroix.org/f-spot/Gallery/
Original comment by sdelcr...@gmail.com
on 13 Dec 2007 at 10:16
Original comment by sdelcr...@gmail.com
on 13 Dec 2007 at 10:27
Hi,
Each image page should show a map below the photo. I have tested the patch with
your
images and it seems, that the GPS-data is embedded as SRationals instead of
Rationals. I have modified the patch to support this.
Andreas Noever
Original comment by andreas....@gmail.com
on 13 Dec 2007 at 12:07
Attachments:
I'd prefer a UI like this one:
http://picasaweb.google.com/sdelcroix/FSpot/photo#5143448572906684018
otherwise, it's ok
Original comment by sdelcr...@gmail.com
on 13 Dec 2007 at 1:29
I have updated the UI and added the map to the index page (including photo
comments).
I had to use a normal button for the "what's this?" link through, Glade# seems
to be
missing support for GtkLinkButton.
Andreas
Original comment by andreas....@gmail.com
on 13 Dec 2007 at 11:04
Attachments:
change looks ok but do not works (for me). I got error messages about wrong api
key... http://www.delcroix.org/f-spot/Gallery/
Original comment by sdelcr...@gmail.com
on 18 Dec 2007 at 9:28
Fixed it. I accidentally removed the placeholder for the apikey while rewriting
the
JavaScript code.
Original comment by andreas....@gmail.com
on 18 Dec 2007 at 10:29
Attachments:
There's still a problem with the generated f-spot-google-maps.html.
The content is there twice, the first time with the api key set, the other one
not.
please test your patches before submitting...
Original comment by sdelcr...@gmail.com
on 19 Dec 2007 at 9:02
Did you apply the patch to a clean svn repo? ( I have tested the patch and it is
working.) patch seems to prepend the content of the file to the already
existing file.
Original comment by andreas....@gmail.com
on 19 Dec 2007 at 12:27
ok, my mistake this time
did you also posed the latest patch to bugzilla ?
am releasing this one, thx for the good job
Original comment by sdelcr...@gmail.com
on 19 Dec 2007 at 3:54
Original comment by sdelcr...@gmail.com
on 19 Dec 2007 at 3:57
The patch is on bugzilla now.
Original comment by andreas....@gmail.com
on 19 Dec 2007 at 5:01
Original issue reported on code.google.com by
lew...@gmail.com
on 27 Nov 2007 at 10:44