shanalikhan / code-settings-sync

🌴💪 Synchronize your Visual Studio Code Settings Across Multiple Machines using GitHub GIST 💪🌴
https://marketplace.visualstudio.com/items?itemName=Shan.code-settings-sync
MIT License
4.02k stars 390 forks source link

Upload will overwrite gist settings even if force upload is turned off with no warnings #1381

Open palapapa opened 1 year ago

palapapa commented 1 year ago

🐛 Describe the bug
Upload will overwrite gist settings even if force upload is turned off with no warnings.

🌴 Visual Studio Code Version : 1.17.2 🌴 Code Settings Sync Version : 3.4.3 🌴 Standard or Insiders : Standard 🌴 Portable or Installed : Installed 🌴 OSS or Official Build : Official 🌴 Operating System : Windows 10 🌴 Occurs On: Upload 🌴 Proxy Enabled: No 🌴 Gist Id: 227dc40cf2a4bc40a8b6aee025d6734d

📰 To Reproduce Steps to reproduce the behavior:

  1. Upload with newer settings on one computer
  2. Upload on another computer with older settings
  3. No warning appears and it directly overwrites the newer settings

💪 Expected behavior A warning asking me if I am sure about uploading the older settings.

📺 Additional context The warning used to appear, but this bug has happened twice this month and I had to revert the settings manually. I usually work on my desktop and upload my settings on it regularly. On holidays I would use my laptop with the older settings I last uploaded with it. Somehow the auto upload would overwrite the gist with the settings from my desktop without asking anything even if force upload is off. I have no idea what caused this since cloudSettings.json should record that the time I last uploaded with my desktop is later than the time I last uploaded with my laptop.